Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev requirements and sphinx conf #1760

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Oct 27, 2021

Fixes #1755

Nbsphinx 0.8.7 exposed that we were setting source_suffix incorrectly so that got updated.

I left off updating to flake8 4.x, maybe tackle it when we start using black

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1760 (284df24) into main (0af409d) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
+ Coverage   98.63%   98.69%   +0.06%     
==========================================
  Files         138      138              
  Lines       15373    15373              
==========================================
+ Hits        15163    15173      +10     
+ Misses        210      200      -10     
Impacted Files Coverage Δ
featuretools/tests/conftest.py 100.00% <0.00%> (+0.40%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.45% <0.00%> (+0.65%) ⬆️
...computational_backends/calculate_feature_matrix.py 99.42% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af409d...284df24. Read the comment docs.

Sphinx==3.2.1
pydata_sphinx_theme==0.4.0
nbconvert==6.2.0
# nbsphinx==0.8.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented line?

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwedge rwedge merged commit a37c08c into main Oct 28, 2021
@rwedge rwedge deleted the update-dev-reqs-nov-oct-2021 branch October 28, 2021 16:02
@rwedge rwedge mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build docs action
2 participants