⚠ Apply predicates on handler instead of passing them to the source #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change add generic versions of event, handler and predicates along the existing ones, prefixed with `Typed`. The existing ones are left in place under the same signature. The `source` constructors are changed to be generic.
…handler with a predicates filter and pass the new handler to the source Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
commented
Apr 22, 2024
| // Channel is used to provide a source of events originating outside the cluster | ||
| // (e.g. GitHub Webhook callback). Channel requires the user to wire the external | ||
| // source (e.g. http handler) to write GenericEvents to the underlying channel. | ||
| func Channel[T any](source <-chan event.TypedGenericEvent[T], handler handler.TypedEventHandler[T], predicates ...predicate.TypedPredicate[T]) Source { | ||
| func Channel[T any](source <-chan event.TypedGenericEvent[T], handler handler.TypedEventHandler[T], options ...ChannelOption) Source { |
There was a problem hiding this comment.
Since the predicates are now passed to WithPredicates instead of this function, we can add an options variadic argument and use that to configure eg. the buffer size.
alvaroaleman
force-pushed
the
compatible-generics
branch
2 times, most recently
from
57151bb
to
2add01e
Compare
|
Implemented in kubernetes-sigs#2783. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed change to kubernetes-sigs#2783.
In kubernetes-sigs#2783, the API of the Source is changed and the handler and predicates are passed to the source when constructed instead of through the Start function.
This PR proposes to further improve that API and make the sources unaware of predicates, instead predicates are used to filter what events are passed to the handler by wrapping the handler and returning a new handler (see WithPredicates function).