Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that renaming model fails #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanfrecce-osaka
Copy link
Contributor

@sanfrecce-osaka sanfrecce-osaka commented Apr 25, 2019

Description

Renaming model fails when pushing save changes button.
The order of the assignments are inappropriate.

Before

Image from Gyazo

@sanfrecce-osaka
Copy link
Contributor Author

sanfrecce-osaka commented Apr 25, 2019

After

Image from Gyazo

Issue

Migration succeeds, but the renamed model isn't displayed on the ER diagram.
The table name is changed but the class name and the file name are not.
How much names do I need to change?

  • File name
    • ex. models/item.rb
  • Class name(definition)
    • ex. class Item < ApplicationRecord end
  • Class name(other places)
    • ex. Item.new
  • Variable name
    • ex. @item

I think that changing names above automatically is difficult.
What do @amatsuda think?

@sanfrecce-osaka sanfrecce-osaka changed the title Fix that rename model is failed Fix that renaming model is failed Apr 27, 2019
@sanfrecce-osaka sanfrecce-osaka changed the title Fix that renaming model is failed Fix that renaming model fails Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant