New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workflow): add release and test workflows #187
Conversation
], | ||
Array [], | ||
Array [ | ||
"Unknown arguments: not-a-valid-option, notAValidOption", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This snapshot has changed with a different value, I assume it is because the new rule fails fast for --parrot-middleware
before yargs sees the invalid arguments
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might become a DX issue if not all arguments are printed in the "help" when an invalid argument is added (typo for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@infoxicator yeah was trying to figure out a way to get the tests to pass but maintain the same functionality.
.github/workflows/tests.yml
Outdated
with: | ||
node-version: ${{ matrix.node }} | ||
- name: Install Dependencies | ||
run: npm ci && npm ls yargs && npm list -g --depth 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this npm ls yargs && npm list -g --depth 0
needed for the yargs issue with GH actions? can you point me to the link where the issue with the yargs version is explained?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I need to remove that 🤦🏼 yargs/yargs#1317
Going to decline this PR for now and wait and see if GitHub fixes their actions |
In order to get this to pass, I needed to change the implies to
demandOption
to
Basically what the implies does, is tell yargs that if
parrot-middleware
ordev-endpoints
is provided,modules
also needs to be provided. So changing it to demand the option when that was the case fixes the snapshot issue that GitHub Actions is having. For some reason GitHub actions is runningyargs@14
at most.