Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(one-app-dev-bundler): avoid default export of sass #543

Merged
merged 2 commits into from Jun 12, 2023

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Jun 12, 2023

Description

Use the documented import API.

Motivation

The "default" export was accidentally removed in sass@1.63.0 through 1.63.3. It will be removed in 2.x per sass/dart-sass#2008. It will likely be added back in 1.63.4 via sass/dart-sass#2009 but we can use the documented API now.

Test Conditions

Jest is not set up to use the ESM import, so the unit tests do not catch the issue. While Jest is being updated in another PR, this has been tested on my machine with a newly generated module using sass@1.63.3.

Types of changes

Check boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist

Check boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

accidentally removed in 1.63.0 through 1.63.3, will be removed in 2.x
sass/dart-sass#2008
@PixnBits PixnBits enabled auto-merge (rebase) June 12, 2023 17:54
@PixnBits PixnBits merged commit 0d9b5b4 into main Jun 12, 2023
5 checks passed
@PixnBits PixnBits deleted the fix/sass-default-export-removal branch June 12, 2023 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants