This repository has been archived by the owner on May 15, 2024. It is now read-only.
fix(webpack): support for jsx-runtime for react<18 with esm #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds aliases to the webpack 5 config to allow webpack to resolve references to
react/jsx-runtime
andreact/jsx-dev-runtime
when being referenced by packages that declare themselves as modules.Motivation
When bundling modules with webpack 5 that contain packages that declare themselves as modules and reference the newer JSX transforms supported by React, Webpack 5 cannot resolve the imports because React<18 does not have an
exports
field in its package.json. When trying to bundle modules that fit this criteria, Webpack 5 outputs the following error:Starting with React 18, the React team have provided an
exports
field in the package.json for React that solves this issue. However, they have declined to bring it into older versions of React: facebook/react#20235.To solve this, we can add aliases to our Webpack config to resolve to the files that these imports refer to: facebook/react#20235 (comment).
Test Conditions
In a test module, I bundled code that imported things from a package that declared itself as a module and referred to
react/jsx-runtime
. Before this change, Webpack output an error. After this change, no errors are output and the module bundles successfully.Types of changes
Checklist