Add derive flag #687
Merged
Add derive flag #687
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorner
commented
Feb 18, 2020
azriel91
reviewed
Feb 24, 2020
src/lib.rs
Outdated
| @@ -39,7 +39,7 @@ | |||
| //! } | |||
| //! ``` | |||
| //! | |||
| //! Or alternatively, if you enable the `specs-derive` feature, you can use a | |||
| //! Or alternatively, if you enable the `specs-derive` or `derive` feature, you can use a | |||
There was a problem hiding this comment.
I think it's alright just mentioning the "derive" feature without mentioning specs-derive.
There was a problem hiding this comment.
OK, I've updated the references through the documentation and tutorials if it's better to just list the one.
I've done a rebase too, since there was a conflict on changelog, but I believe with a diff this small the added difficulty to review is basically none.
* There are currently two distinct *-derive features and it is uncomfortable to hunt for them. * They exist mostly due to technical reasons, as they bring two different crates. The price of the other if one is already present is relatively low (the cost is by depending on syntax and quote and they share them). * This is in the convention of having the `derive` feature flag as serde and other packages have. * The original two are still preserved, so users still can enable only one of them. Closes #684.
|
bors r+ |
Build succeeded |
|
Thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncomfortable to hunt for them.
different crates. The price of the other if one is already present is
relatively low (the cost is by depending on syntax and quote and they
share them).
derivefeature flag as serdeand other packages have.
one of them.
Closes #684.
Checklist
Should I update the examples to use this feature, or leave them be with the current
specs-derive?I'm not sure this completely applies. I've updated the note in docs about features, but otherwise left the
specs-deriveas the main suggestion how to use it by users and expect this will be more like for people who go more by guess than by documentation. But if you prefer, I can update all the examples, etc, to use this new feature flag instead.API changes