Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
API changes
#[non_exhaustive]
forerror::Error
instead of__NonExhaustive
trick. This is a breaking change, and requires a minimal Rust version of 1.40 (previously 1.38). This notably enables to add new error types without it being a breaking change.std::error::Error
implementation of different error types, to use "state of the art" functions instead of deprecated ones.NoError
and usestd::convert::Infallible
, and re-export the latter asNoError
for a smoother transition (maybe we should remove completly). This will also allow a smoother transition to never type when it is stabilized.