Few ideas for fluentRevealNavbar.uc.js #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminomancer
requested changes
Jul 23, 2023
| if (el.disabled || areaStyle.pointerEvents == "none") { | ||
| // previous pointerEvents check may break the effect in FF 115 | ||
| //if (el.disabled || areaStyle.pointerEvents == "none") { | ||
| if (el.disabled) { | ||
| return this.clearEffect(area); | ||
| } | ||
|
|
There was a problem hiding this comment.
The code below needs to be fixed, or there is a bug when you move the mouse around the top of the page on about:config or about:preferences, etc. It's because they are in the parent process so their true event targets pass all the way up to the chrome window listener (normally the event target we see would be <browser>).
It's better if we just use MousePosTracker.
let x = MousePosTracker._x - this.getOffset(area).left - window.scrollX;
let y = MousePosTracker._y - this.getOffset(area).top - window.scrollY;There was a problem hiding this comment.
Sorry, I didn't know about this bug, so my first thought was this check was added just for UX convenience. So now this should be handled by new getComputedStyle(el).pointerEvents == "none" check, right?
aminomancer
reviewed
Jul 23, 2023
aminomancer
requested changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pointerEvents=noneon navbar button, which resulted in script not working for me on FF 115filterDy, which don't process mouse movements greater than {gradientSize}px from top of the screen, in order to reduce system load (default: true)cacheButtons, which stores all toolbar buttons on script init and then reuses the list on each draw iteration (default: false)includeUrlBar, which applies effect to url bar as well (when it's not focused) (default: true)