16 tests #23
Merged
16 tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zatziky
commented
Apr 14, 2019
•
zatziky
commented
- I couldn't find a way how to make it run with mocha.opts. I've also tried to replace mocha with jest. This is the only workaround I have found - feat: default url in register.js component preventing SecurityError rstacruz/jsdom-global#50
karelrochelt
approved these changes
Apr 16, 2019
test/connect.spec.js
Outdated
|
|
||
| import chai from 'chai' | ||
| import amioChat from '../lib/amio-chat-sdk-web' | ||
| // import {amioChat} from '../src/amio-chat-client' |
src/amio-chat-client.js
Outdated
| @@ -15,7 +16,22 @@ class AmioChatClient { | |||
| return connection.connect(config) | |||
| } | |||
|
|
|||
| // TODO to docs | |||
There was a problem hiding this comment.
Let's not submit code with TODOs and undocumented functions
karelrochelt
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.