Skip to content

Commit

Permalink
Fix bathPathMapping filtering with the allowPathMatching enabled.
Browse files Browse the repository at this point in the history
  • Loading branch information
rddimon committed Jan 29, 2024
1 parent 40eaf7a commit 8f9408b
Show file tree
Hide file tree
Showing 13 changed files with 607 additions and 550 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [7.3.4] - 2023-01-30

### Fixed
- Fixed bathPathMapping filtering with the `allowPathMatching` enabled.

## [7.3.3] - 2023-12-07

### Changed
Expand Down
54 changes: 27 additions & 27 deletions README.md

Large diffs are not rendered by default.

168 changes: 84 additions & 84 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
@@ -1,6 +1,6 @@
{
"name": "serverless-domain-manager",
"version": "7.3.3",
"version": "7.3.4",
"engines": {
"node": ">=14"
},
Expand Down Expand Up @@ -51,15 +51,15 @@
},
"devDependencies": {
"@types/mocha": "^10.0.6",
"@types/node": "^20.10.0",
"@types/node": "^20.11.10",
"@types/randomstring": "^1.1.11",
"@types/shelljs": "^0.8.15",
"aws-sdk-client-mock": "^3.0.0",
"chai": "^4.3.10",
"aws-sdk-client-mock": "^3.0.1",
"chai": "^4.4.1",
"chai-spies": "^1.1.0",
"eslint": "^7.32.0",
"eslint-config-standard": "^16.0.3",
"eslint-plugin-import": "^2.29.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^5.2.0",
"@typescript-eslint/parser": "^5.62.0",
Expand All @@ -71,7 +71,7 @@
"serverless": "^3.38.0",
"serverless-plugin-split-stacks": "^1.13.0",
"shelljs": "^0.8.5",
"ts-node": "^10.9.1",
"ts-node": "^10.9.2",
"typescript": "^5.1.6 && <5.2"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions src/aws/api-gateway-v1-wrapper.ts
Expand Up @@ -152,6 +152,8 @@ class APIGatewayV1Wrapper extends APIGatewayBase {
}

public async updateBasePathMapping (domain: DomainConfig): Promise<void> {
Logging.logInfo(`V1 - Updating API mapping from '${domain.apiMapping.basePath}'
to '${domain.basePath}' for '${domain.givenDomainName}'`);
try {
await this.apiGateway.send(new UpdateBasePathMappingCommand({
basePath: domain.apiMapping.basePath,
Expand All @@ -163,11 +165,9 @@ class APIGatewayV1Wrapper extends APIGatewayBase {
}]
}
));
Logging.logInfo(`V1 - Updated API mapping from '${domain.apiMapping.basePath}'
to '${domain.basePath}' for '${domain.givenDomainName}'`);
} catch (err) {
throw new Error(
`V1 - Unable to update base path mapping for '${domain.givenDomainName}':\n${err.message}`
`V1 - Unable to update base path mapping for '${domain.givenDomainName}':\n${err.message}`
);
}
}
Expand Down

0 comments on commit 8f9408b

Please sign in to comment.