Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pagination when there are too many certificates fixes #314 #315

Merged
merged 2 commits into from Apr 21, 2020
Merged

Use pagination when there are too many certificates fixes #314 #315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2948c62
Use pagination when there are too many certificates fixes #314
glc-gplassard Feb 24, 2020
8475ff2
Merge branch 'master' into master
jconstance-amplify Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 9 additions & 4 deletions index.ts
View file
Open in desktop
Expand Up @@ -260,13 +260,18 @@ class ServerlessCustomDomain {

let certificateArn; // The arn of the choosen certificate
let certificateName = this.serverless.service.custom.customDomain.certificateName; // The certificate name
let certData;
try {
certData = await this.acm.listCertificates(
{ CertificateStatuses: certStatuses }).promise();
let certificates = [];
let nextToken;
do {
const certData = await this.acm.listCertificates(
{ CertificateStatuses: certStatuses, NextToken: nextToken }).promise();
certificates = certificates.concat(certData.CertificateSummaryList);
nextToken = certData.NextToken;
} while (nextToken);

// The more specific name will be the longest
let nameLength = 0;
const certificates = certData.CertificateSummaryList;

// Checks if a certificate name is given
if (certificateName != null) {
Expand Down