Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version and readme for version 4 release #329

Merged
merged 6 commits into from May 6, 2020

Conversation

aoskotsky-amplify
Copy link
Member

@aoskotsky-amplify aoskotsky-amplify commented May 6, 2020

Release changes from #319. Bumping with major version change due to the big refactoring that was done but we aren't aware of any breaking changes at the moment.

@tehnrd
Copy link
Contributor

tehnrd commented May 6, 2020

Since this is going with a 4.0 release maybe it makes sense to change the commands to create_domains and delete_domains (making them plural with an s). It would also prepare for #327 . I didn't change these names in order to keep backward compatibility and perhaps it's best to maintain that still.

I have no preference and most use cases will probably be a single domain....so perhaps it's best to leave as is, but just wanted to bring it up as if there was ever a time to change it, it would be at a major release.

@tehnrd
Copy link
Contributor

tehnrd commented May 6, 2020

....or just add both, but internally call the same functions. Ya...that probably makes more sense, that can be part of #327

@aoskotsky-amplify
Copy link
Member Author

I think it's fine to keep create_domain and delete_domain to minimize the amount of breaking changes in this release. In a future release, we could include #323 and deprecate the existing commands.

I guess #327 should be changed so the plugin supports either a map, list or single domain config. It could be either a 4.1.0 or 5.0.0 release depending on how much needs to be refactored again.

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aoskotsky-amplify aoskotsky-amplify merged commit 2576641 into master May 6, 2020
@aoskotsky-amplify aoskotsky-amplify deleted the release_version_4 branch May 6, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants