New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add autoDomain and autoDomainWaitFor option to config #356
Merged
jconstance-amplify
merged 4 commits into
amplify-education:master
from
bryan-hunter:add-auto-create-domain
Jul 14, 2020
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,6 +76,7 @@ async function sleep(seconds) { | |
} | ||
|
||
export { | ||
sleep, | ||
getAWSPagedResults, | ||
throttledCall, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
"use strict"; | ||
|
||
module.exports.helloWorld = (event, context, callback) => { | ||
const response = { | ||
statusCode: 200, | ||
headers: { | ||
"Access-Control-Allow-Origin": "*", // Required for CORS support to work | ||
}, | ||
body: JSON.stringify({ | ||
message: "Go Serverless v1.0! Your function executed successfully!", | ||
input: event, | ||
}), | ||
}; | ||
|
||
callback(null, response); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# create_domain should be run as part of deployment | ||
service: auto-domain-${opt:RANDOM_STRING} | ||
provider: | ||
name: aws | ||
runtime: nodejs12.x | ||
region: us-west-2 | ||
stage: test | ||
functions: | ||
helloWorld: | ||
handler: handler.helloWorld | ||
events: | ||
- http: | ||
path: hello-world | ||
method: get | ||
cors: true | ||
plugins: | ||
- serverless-domain-manager | ||
custom: | ||
customDomain: | ||
domainName: auto-domain-${opt:RANDOM_STRING}.${env:TEST_DOMAIN} | ||
basePath: '' | ||
autoDomain: true | ||
autoDomainWaitFor: 120 | ||
|
||
package: | ||
exclude: | ||
- node_modules/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we exit this for loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if all
domains
exist , thenatLeastOneDoesNotExist()
will be false and exit (await this.getDomainInfo();
in the for loop will repopulate data so it can go from true/false)otherwise, if it never populates, the
i * pollInterval
will eventually be greater thanmaxWaitFor
and it'll exit and the deployment will eventually fail in the same way as if you never rancreate_domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jconstance-amplify let me know what you think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jconstance-amplify bump :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jconstance-amplify no vacations allowed!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately for you I came back on Monday! :D