Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sampsasaarela: fetch exports from cloudformation if used Fn::ImportValue #380

Merged
merged 13 commits into from Sep 16, 2020

Conversation

rddimon
Copy link
Collaborator

@rddimon rddimon commented Sep 9, 2020

This PR for resolving conflicts of #220

Examples of usage:
export config file: test/integration-tests/basic/apigateway-with-export/serverless.yml
import config file: test/integration-tests/basic/apigateway-with-import/serverless.yml

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@rddimon
Copy link
Collaborator Author

rddimon commented Sep 16, 2020

Integration tests passed

Screen Shot 2020-09-16 at 1 26 28 PM

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 15 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@aoskotsky-amplify aoskotsky-amplify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rddimon rddimon merged commit f12f020 into master Sep 16, 2020
@rddimon rddimon deleted the sampsasaarela-add-fn-importvalue-support branch September 16, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create basepath mapping when using Fn::ImportValue for restApiId in serverless.yml
3 participants