Fix stage name handling #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rddimon
approved these changes
Jul 18, 2023
src/index.ts
Outdated
| @@ -365,6 +365,12 @@ class ServerlessCustomDomain { | |||
| domain.domainInfo = await apiGateway.getCustomDomain(domain); | |||
|
|
|||
| if (!domain.apiMapping) { | |||
| if (domain.apiType === Globals.apiTypes.http) { | |||
| Logging.logWarning( | |||
| "Make sure that the API Mapping with the `$default` stage already exists. " + | |||
There was a problem hiding this comment.
Hmm what are people supposed to do when they see this warning?
| @@ -27,11 +27,13 @@ custom: | |||
| basePath: '' | |||
| endpointType: REGIONAL | |||
| autoDomain: true | |||
| stage: '$default' | |||
There was a problem hiding this comment.
Is this required now? This could be considered a breaking change. Is it possible to default to $default for http APIs?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578
Description of Issue Fixed
Changes proposed in this pull request:
retryStrategyfor the APiGateway clients in caseToManyRequestserror or such