Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bathPathMapping filtering with the allowPathMatching enabled. #614

Merged
merged 2 commits into from Jan 30, 2024
Merged

Fix bathPathMapping filtering with the allowPathMatching enabled. #614

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f9408b
Fix bathPathMapping filtering with the `allowPathMatching` enabled.
rddimon Jan 29, 2024
216bdea
Update integration tests
rddimon Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [7.3.4] - 2023-01-30

### Fixed
- Fixed bathPathMapping filtering with the `allowPathMatching` enabled.

## [7.3.3] - 2023-12-07

### Changed
Expand Down
54 changes: 27 additions & 27 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

168 changes: 84 additions & 84 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "serverless-domain-manager",
"version": "7.3.3",
"version": "7.3.4",
"engines": {
"node": ">=14"
},
Expand Down Expand Up @@ -51,15 +51,15 @@
},
"devDependencies": {
"@types/mocha": "^10.0.6",
"@types/node": "^20.10.0",
"@types/node": "^20.11.10",
"@types/randomstring": "^1.1.11",
"@types/shelljs": "^0.8.15",
"aws-sdk-client-mock": "^3.0.0",
"chai": "^4.3.10",
"aws-sdk-client-mock": "^3.0.1",
"chai": "^4.4.1",
"chai-spies": "^1.1.0",
"eslint": "^7.32.0",
"eslint-config-standard": "^16.0.3",
"eslint-plugin-import": "^2.29.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^5.2.0",
"@typescript-eslint/parser": "^5.62.0",
Expand All @@ -71,7 +71,7 @@
"serverless": "^3.38.0",
"serverless-plugin-split-stacks": "^1.13.0",
"shelljs": "^0.8.5",
"ts-node": "^10.9.1",
"ts-node": "^10.9.2",
"typescript": "^5.1.6 && <5.2"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions src/aws/api-gateway-v1-wrapper.ts
View file
Open in desktop
Expand Up @@ -152,6 +152,8 @@ class APIGatewayV1Wrapper extends APIGatewayBase {
}

public async updateBasePathMapping (domain: DomainConfig): Promise<void> {
Logging.logInfo(`V1 - Updating API mapping from '${domain.apiMapping.basePath}'
to '${domain.basePath}' for '${domain.givenDomainName}'`);
try {
await this.apiGateway.send(new UpdateBasePathMappingCommand({
basePath: domain.apiMapping.basePath,
Expand All @@ -163,11 +165,9 @@ class APIGatewayV1Wrapper extends APIGatewayBase {
}]
}
));
Logging.logInfo(`V1 - Updated API mapping from '${domain.apiMapping.basePath}'
to '${domain.basePath}' for '${domain.givenDomainName}'`);
} catch (err) {
throw new Error(
`V1 - Unable to update base path mapping for '${domain.givenDomainName}':\n${err.message}`
`V1 - Unable to update base path mapping for '${domain.givenDomainName}':\n${err.message}`
);
}
}
Expand Down