New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle null from getDeviceId() #126

Closed

justin-fiedler wants to merge 1 commit into main from AMP-55315-crash-trying-to-obtain-null-device-id

Contributor

justin-fiedler commented Jun 10, 2022 •

edited

Update TS interface to have getDeviceId(): Promise<string|null>

Since in Java String can be null and I think the casting to a string might be the root cause of the linked issue.


          fix: handle null from getDeviceId()

87d5335

justin-fiedler requested review from yuhao900914 and qingzhuozhen

June 10, 2022 22:58

justin-fiedler linked an issue

that may be closed by this pull request

Invalid TS return type for getDeviceId() #121

Open

justin-fiedler closed this

justin-fiedler deleted the AMP-55315-crash-trying-to-obtain-null-device-id branch

June 10, 2022 23:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment