Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg packages after v11.9.0 release #6716

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Nov 12, 2021

No description provided.

@pierlon pierlon added the dependencies Pull requests that update a dependency file label Nov 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2021

Plugin builds for 4888e6e are ready 🛎️!

@westonruter
Copy link
Member

This is causing the lockfileVersion to change from 1 to 2, which I had to undo before in #6713. It makes sense that it would do this given that the .nvmrc has LTS, and Node v16 is now LTS. But neither WordPress core nor Gutenberg have seemingly updated to Node v16 even though they're on LTS, so their lockfileVersions are still at 1. Looks like this was going to be done in Gutenberg via WordPress/gutenberg#33892 but it was halted to do the same time as WP core in v5.9.

@westonruter
Copy link
Member

Maybe this is all that is required:

diff --git a/package.json b/package.json
index fc2296a1f..c80d984b1 100644
--- a/package.json
+++ b/package.json
@@ -20,7 +20,7 @@
   },
   "engines": {
     "node": ">= 14",
-    "npm": ">= 6.14"
+    "npm": ">= 6.14 <7"
   },
   "dependencies": {
     "@wordpress/api-fetch": "5.2.5",

@pierlon pierlon merged commit 92453d4 into develop Nov 12, 2021
@pierlon pierlon deleted the update/gutenberg-v11.9.0-packages branch November 12, 2021 04:24
@westonruter westonruter added this to the v2.2 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants