Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container readme and dockerfile #6693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

powerivq
Copy link
Collaborator

Since amp.dev became a static site, it no longer makes sense to differentiate dev and prod environment. We therefore move everything to the main Dockerfile and adjust the documentation.

Copy link

@Vue-Pu Vue-Pu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker container README and dockerfile #6693

@erwinmombay
Copy link
Member

heya @Vue-Pu , i kindly ask you to stop spamming our repositories

@Vue-Pu
Copy link

Vue-Pu commented Feb 22, 2024

@erwinmombay sorry i thought i have been working on my fork repository can you revert where my approved commit wont affect yours and or if there is something in my end to also undo provide me the steps to do so biggest apologies

@ychsieh
Copy link
Collaborator

ychsieh commented Feb 22, 2024

@Vue-Pu I am assuming you mean you thought you were pulling these public PRs to your own fork? If you are working on your own changes to pull into your own fork, you don't need to approve anything to do so.

So the only thing you need do is to stop approving these PRs(or leaving irrelevant comments), because it has nothing to do with your own fork. If you want to make your fork up-to-date, just remember to merge with the main branch.

Hope that helps.

Copy link

@Vue-Pu Vue-Pu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker Container ad Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants