Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameters for rcmwidget extension for amp-ad #39158

Open
Bob-chemist opened this issue Jun 16, 2023 · 2 comments · May be fixed by #39173
Open

Change parameters for rcmwidget extension for amp-ad #39158

Bob-chemist opened this issue Jun 16, 2023 · 2 comments · May be fixed by #39173
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code

Comments

@Bob-chemist
Copy link
Contributor

Bob-chemist commented Jun 16, 2023 •
edited

Summary

Hi!
One of parameters (projectId) of out widget is outdated and should be removed from the list. And I want to contribute this change into amp-ad.

And 1 param should be added to required params: layoutType. We don't need it anymore.

Widget is used to place dynamic blocks with the most relevant materials on Rambler sites.

Design Document

No response

Motivation

One of params became unnecessary, so I want to remove it from the list of params.

Alternative Solutions

no

Launch Tracker

No response

Notifications

/cc @ampproject/wg-approvers
@Bob-chemist Bob-chemist added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Jun 16, 2023
@Bob-chemist Bob-chemist mentioned this issue Jun 16, 2023
Closed
@Delgado2023 Delgado2023 linked a pull request Jun 19, 2023 that will close this issue
Open
@Bob-chemist
Copy link
Contributor Author

Bob-chemist commented Jun 20, 2023 •
edited

we need to add 1 more param to required params: layoutType.

I have edited startpost

@Bob-chemist Bob-chemist changed the title Remove outdated parameter from rcmwidget extension for amp-ad Change parameters for rcmwidget extension for amp-ad Jun 20, 2023
@Bob-chemist
Copy link
Contributor Author

sorry, now we don't need param layoutType.

I have edited startpost again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code
Projects
None yet
Milestone
No milestone
1 participant
@Bob-chemist