Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit params for rcmwidget #39173

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Delgado2023
Copy link

Remove outdated param

Closes #39158

cc ampproject/wg-monetization

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2023

CLA assistant check
All committers have signed the CLA.

@Delgado2023 Delgado2023 changed the title Remove 1 param from rcmwidget Edit params for rcmwidget Jun 20, 2023
@erwinmombay erwinmombay requested review from powerivq and removed request for calebcordry June 20, 2023 16:36
@Delgado2023
Copy link
Author

@powerivq, can you review this PR please?

@powerivq
Copy link
Contributor

powerivq commented Jun 26, 2023

This contribution is undergoing review.

@Delgado2023
Copy link
Author

@powerivq, any news?

@Delgado2023
Copy link
Author

@powerivq, I've searched the whole site of openjs foundation, but found nothing about any kind of sanctions.

@Delgado2023
Copy link
Author

@erwinmombay, could you please answer me?

@Delgado2023
Copy link
Author

Issue updated again, and I've pushed new commit. Still have hope))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change parameters for rcmwidget extension for amp-ad
4 participants