Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump worker-dom to 0.30.1 #35108

Merged
merged 2 commits into from
Jul 2, 2021
Merged

bump worker-dom to 0.30.1 #35108

merged 2 commits into from
Jul 2, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Jul 1, 2021

summary

  • Bumps the version number to the latest worker-dom.
  • This includes localStorage support in nodom mode.

@samouri samouri self-assigned this Jul 1, 2021
@samouri samouri requested review from kristoferbaxter and removed request for kristoferbaxter July 1, 2021 20:30
@samouri
Copy link
Member Author

samouri commented Jul 2, 2021

Genuine error here, worker-dom@0.30.0 is broken.
Errors in the worker logs were about missing classes, i.e. "CharacterData not defined".

I'm assuming the culprit is ampproject/worker-dom#1067, but still investigating.

@samouri samouri changed the title bump worker-dom to 0.30.0 bump worker-dom to 0.30.1 Jul 2, 2021
@samouri samouri marked this pull request as ready for review July 2, 2021 20:39
@samouri samouri enabled auto-merge (squash) July 2, 2021 20:39
@samouri samouri merged commit 1eb0151 into ampproject:main Jul 2, 2021
@samouri samouri deleted the bumpdom branch July 2, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

Assignees

@samouri samouri

Labels
WG: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samouri @kristoferbaxter