Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bento: Fix unrecognized DOM attributes #36151

Merged
merged 8 commits into from Sep 24, 2021

Conversation

caroqliu
Copy link
Contributor

@caroqliu caroqliu commented Sep 23, 2021

Updates:

  • removed allowTransparency due to Remove allow transparency facebook/react#10823
  • lowercased allowfullscreen
  • removed expanded from final render state of BentoAccordionSection
  • removed keyboardSelectMode from final render state of BentoSelector
  • removed thumbnailSrc from final render state of slide children of BentoBaseCarousel
  • renamed given ariaLabel prop to aria-label on BentoVideo

In a follow up PR, the expanded prop should be removed from final render state of BentoAccordionSection, but it is not done so in this PR because it is more involved and has implications on the AMP mode shims.

The following changes specifically were not made as the left hand side is preferred for preact and the right hand is preferred for react, therefore we need our build to account for these instead of changes to the sourcecode:

  • allowfullscreen -> allowFullScreen
  • class -> className
  • datetime -> dateTime
  • frameborder -> frameBorder
  • srcset -> srcSet
  • svg kebab-case -> svg camel case

Partial for #35553

@caroqliu caroqliu marked this pull request as ready for review September 23, 2021 19:09
@amp-owners-bot
Copy link

Hey @westonruter, @ediamin! These files were changed:

extensions/amp-wordpress-embed/1.0/component.js

@caroqliu caroqliu changed the title Bento: Fix invalid DOM props Bento: Fix unrecognized DOM attributes Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants