Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT SUBMIT] Pr/39430 #39431

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[DO NOT SUBMIT] Pr/39430 #39431

wants to merge 16 commits into from

Conversation

erwinmombay
Copy link
Member

No description provided.

Googler and others added 15 commits September 1, 2023 18:35
@banaag
Migrate from cfg = "host" to cfg = "exec"
7ae1b33 
PiperOrigin-RevId: 488423550
@banaag
...Fix risky undefined behavior when host is empty....
4e56ae2 
PiperOrigin-RevId: 488505778
@amaltas @banaag
Allow ampjs domain for serving amp js files.
ed02983 
PiperOrigin-RevId: 489206825
@banaag
No description.
abb8682 
PiperOrigin-RevId: 491684683
@banaag
Explicitly cast a char32_t to uint32_t before streaming it to output.
09a2abc 
In C++17, the char32_t is silently formatted as a number, but in C++20, overloads of << accepting wide character types are deleted, breaking compilation of this code.

The value also was formatted in decimal afaict, but all other values here are formatted in hex, so do that here as well.

PiperOrigin-RevId: 499523425
@banaag
Fix AMP for Email spec URLs
65066bf 
Some of these URLs are pointing to the AMP for Website documentation.

PiperOrigin-RevId: 508406092
@amaltas @banaag
Replace greggrothaus (now a xoogler) with Erwin in OWNERs file.
6e2666c 
Edited README to:
- Move htmlparser out of beta. It is pretty stable and running in several production services since 2019.
- Remove references of being maintained by AMP working group, as it will be maintained by ex-engineers of working group.

PiperOrigin-RevId: 518921324
@banaag
Internal Code Change
7d9f69f 
PiperOrigin-RevId: 540320460
@banaag
Internal Code Change
8bebc48 
PiperOrigin-RevId: 540323049
@banaag
Internal Code Change
803ed45 
PiperOrigin-RevId: 540325424
@banaag
Fixed lint errors for license.
cab0b36 
PiperOrigin-RevId: 543822678
@amaltas @banaag
Various lint fixes.
457a5d6 
PiperOrigin-RevId: 555248479
@amaltas @banaag
Few more lint errors/warnings fixes.
c4b6280 
PiperOrigin-RevId: 555259013
@amaltas @banaag
Create announce mailing list to notify important updates to clients.
72faeef 
PiperOrigin-RevId: 557610815
@banaag
Mark htmlparser Node.DebugString as const.
569901b 
PiperOrigin-RevId: 558192832
@amp-owners-bot
Copy link

amp-owners-bot bot commented Sep 1, 2023 •
edited by ampprojectbot

Hey @ampproject/wg-caching! These files were changed:

validator/cpp/engine/BUILD
validator/cpp/engine/embed_data.bzl
validator/cpp/engine/testing-utils.cc
validator/cpp/engine/validator-internal.cc
validator/cpp/engine/validator_test.cc
validator/cpp/engine/wasm/BUILD
validator/cpp/htmlparser/README.md
validator/cpp/htmlparser/allocator.h
validator/cpp/htmlparser/allocator_test.cc
validator/cpp/htmlparser/atomutil.cc
validator/cpp/htmlparser/bin/atomgen.cc
validator/cpp/htmlparser/bin/casetablegen.cc
+38 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erwinmombay @amaltas @banaag