Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document.location (WIP) #1075

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

niutech
Copy link
Contributor

@niutech niutech commented Jul 12, 2021

This is a first draft of document.location support (issue #1068). It is not tested nor complete yet. Could anybody please pick up the changeset and test it? It is hard for me to understand the Worker-DOM internals, how the transfer of complex objects such as Location works between main thread and worker.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


niutech seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@niutech
Copy link
Contributor Author

niutech commented Jul 12, 2021

I don't know why I have errors like: src/main-thread/commands/object-creation.ts(69,47): error TS2304: Cannot find name 'RenderableElement'. even thought I didn't change this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants