fix: check buildPath consistently #1143
Open
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if I can get this into v3, @dbanksdesign this fix and this one are waiting for your approval, might be nice to do another v3 release since v4 is still in prerelease/alpha stage. I'll make sure to port this fix to v4, it's slightly more nuanced of a fix there since it has to be browser-compatible as well, and in browsers a filesystem shim is used that uses posix separators regardless of whether the user agent is Windows. For v3 this fix is fine though! |
jorenbroekema
approved these changes
Apr 1, 2024
|
@jorenbroekema Thanks for the review! @dbanksdesign LMK if there's anything else needed from my side to help get this landed for a v3 release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1144
Description of changes:
Extracted
buildPath-checking logic to its own util and ensure it uses the platform-specific separator.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.