Work on code generation for C# / .NET (MAUI) #1162
Conversation
|
What I am struggling with, is
The use case is this:
|
| * @typedef {import('../../../../types/File.d.ts').File} File | ||
| * @typedef {import('../../../../types/Config.d.ts').LocalOptions} LocalOptions | ||
| */ | ||
|
|
| @@ -157,5 +157,13 @@ | |||
| "unist-util-visit": "^5.0.0", | |||
| "uuid": "^9.0.1", | |||
| "yaml": "^2.3.4" | |||
| }, | |||
| "mocha": { | |||
There was a problem hiding this comment.
Ah cool, then we can also remove these params in the scripts['test:node'] for brevity right?
|
It sounds like what you're looking for is something that is similar to |
| const file = setCSharpFileProperties({ | ||
| accessModifier: 'public', | ||
| }); | ||
| expect(file.accessModifier).to.equal('public '); |
There was a problem hiding this comment.
| expect(file.accessModifier).to.equal('public '); | |
| expect(file.accessModifier).to.equal('public'); |
I think it's better to add the needed whitespace later in the format itself rather than doing it here. A few days ago I refactored all of the existing templates and also this file: https://github.com/amzn/style-dictionary/blob/v4/lib/common/formatHelpers/setSwiftFileProperties.js#L50 and then add the whitespacing here: https://github.com/amzn/style-dictionary/blob/v4/lib/common/templates/ios-swift/any.swift.template.js#L24
| */ | ||
| export default function setCSharpFileProperties(options) { | ||
| if (typeof options.accessModifier === 'undefined') { | ||
| options.accessModifier = 'public '; |
There was a problem hiding this comment.
| options.accessModifier = 'public '; | |
| options.accessModifier = 'public'; |
| options.accessModifier = 'public '; | ||
| } else { | ||
| if (options.accessModifier !== '') { | ||
| options.accessModifier = `${options.accessModifier} `; |
There was a problem hiding this comment.
| options.accessModifier = `${options.accessModifier} `; | |
| options.accessModifier = `${options.accessModifier}`; |
|
I reviewed your PR thusfar and it looks great! let me know if there's anything I can help with, you can also reach me on Slack if you wanna have a call at some point to flesh out some of the details |
Issue #, if available: #977
Description of changes:
Export tokens to C# class format, so that they are also usable in C#, and so that you can generate compilable code. This is intended to be usable in .NET MAUI.
Colornumbers /dimensionsstringshadowBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.