Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update deps to Nx 15.6.3, nitropack 1.0.0, astro 2.0.2 #232

Merged
merged 1 commit into from
Jan 30, 2023
Merged

build: update deps to Nx 15.6.3, nitropack 1.0.0, astro 2.0.2 #232

merged 1 commit into from
Jan 30, 2023

Conversation

himyjan
Copy link
Contributor

@himyjan himyjan commented Jan 25, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router
  • platform
  • content

What is the current behavior?

Issue Number: N/A

What is the new behavior?

update blog-app to React 18.2.0
update Nx 15.6.2, typescript 4.9.4, nitropack 1.0.0 (support node 19), astro 2.0.1, cypress 12.4.0
update create-analog template-angular-v14, template-angular-v15 package version

nitropack 0.6.0 1.0.0 working -> nitropack 2.0.0 2.1.0 2.1.1 2.2.0 2.2.1 api not working http://localhost:3000/api/v1/products
image

react 18 with docusaurus 2.3.0 build error will fix in 2.3.1 version
facebook/docusaurus#8592

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 63dec7f
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63d7dc48bed0600008629370
😎 Deploy Preview https://deploy-preview-232--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 63dec7f
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/63d7dc484cd10600088eeb70
😎 Deploy Preview https://deploy-preview-232--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 63dec7f
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63d7dc4ca69cbe00084dde91
😎 Deploy Preview https://deploy-preview-232--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@himyjan himyjan changed the title build: update deps to Nx 15.4.5, nitropack 2.0.0 build: update deps to Nx 15.6.2, nitropack 2.0.0 Jan 25, 2023
@himyjan himyjan changed the title build: update deps to Nx 15.6.2, nitropack 2.0.0 build: update deps to Nx 15.6.2, astro 2.0.1 Jan 25, 2023
@himyjan himyjan changed the title build: update deps to Nx 15.6.2, astro 2.0.1 build: update deps to Nx 15.6.2, nitropack 1.0.0, astro 2.0.1 Jan 25, 2023
packages/create-analog/template-angular-v14/package.json Outdated Show resolved Hide resolved
packages/create-analog/template-angular-v15/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@himyjan himyjan closed this Jan 26, 2023
@himyjan himyjan reopened this Jan 26, 2023
@himyjan himyjan changed the title build: update deps to Nx 15.6.2, nitropack 1.0.0, astro 2.0.1 build: update deps to Nx 15.6.2, nitropack 1.0.0, astro 2.0.2 Jan 29, 2023
@himyjan himyjan changed the title build: update deps to Nx 15.6.2, nitropack 1.0.0, astro 2.0.2 build: update deps to Nx 15.6.3, nitropack 1.0.0, astro 2.0.2 Jan 29, 2023
@brandonroberts brandonroberts merged commit d7e04f3 into analogjs:main Jan 30, 2023
Comment on lines +19 to +20
"react": "18.2.0",
"react-dom": "18.2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question but why do you want to use React 18 when Docusauurs does not provide yet official support?

You could as well stay on React 17 and use Docusaurus 2.3 (the recommended setup)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't know it wasn't fully supported yet. I'm fine with going back to the recommended setup for now

Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants