fix: undefined viteServer #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
brandonroberts
approved these changes
Feb 27, 2023
|
Thanks! @allcontributors add @sand4rt for code |
|
I've put up a pull request to add @sand4rt! 🎉 |
|
@sand4rt the fix has been published in |
|
@brandonroberts Awesome! BTW, i integrated the plugin in this PR microsoft/playwright#21208. It does run a bit slower than the other frameworks but still acceptable in my opinion. If you have time, i'm very curious about what you think of it and whether you see things that could be improved. |
Villanuevand
pushed a commit
to Villanuevand/analog
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Build crashes when
process.env['NODE_ENV'] === 'test' || !!process.env['VITEST']istrueandviteServerisundefined.What is the new behavior?
The build won't crash when
viteServerisundefined.Does this PR introduce a breaking change?
Other information
Exploring your repo about Playwright component testing and trying to avoid requiring users to install the Vite plugin and specify the tsconfig.
Hence i'm setting
process.env['NODE_ENV']environment variable to'test'so that the Vite plugin can resolve this by it self: https://github.com/analogjs/analog/blob/main/packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts#L53The build will fail when i do this because
viteServerwill beundefinedin this scenario.Related to: microsoft/playwright#14153 (comment)