Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsx-tide checker modes #464

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Conversation

phuhl
Copy link
Contributor

@phuhl phuhl commented Apr 27, 2023

Fixes #463

@ananthakumaran
Copy link
Owner

Could you confirm if autocomplete works for you? It also uses typescript-ts-base-mode

@phuhl
Copy link
Contributor Author

phuhl commented Apr 27, 2023

It works. I have that feeling that it does less then before, though. Not sure how that can be.

@ananthakumaran
Copy link
Owner

You can run M-x company-diag to check which backends are used.

@phuhl
Copy link
Contributor Author

phuhl commented Apr 28, 2023

Seems to be the wrong one?

Emacs 29.0.90 (x86_64-pc-linux-gnu) of 2023-04-26 on ...
Company 0.9.13

company-backends: (company-tide company-bbdb company-semantic company-cmake company-capf company-clang company-files
              (company-dabbrev-code company-gtags company-etags company-keywords)
              company-oddmuse company-dabbrev)

Used backend: company-dabbrev
Major mode: tsx-ts-mode
Prefix: ""

Could you point me to what I need to change to use company-tide?

@ananthakumaran
Copy link
Owner

Can you add the modes to tide-supported-modes. Sorry I don't have the emacs 30 setup to verify these things.

@phuhl
Copy link
Contributor Author

phuhl commented Apr 28, 2023

No worries. Seems to work with the modes added in tide-supported-modes. Added a commit for it.

@ananthakumaran ananthakumaran merged commit ea47d8f into ananthakumaran:master Apr 28, 2023
10 checks passed
@cprussin
Copy link

cprussin commented Jun 4, 2023

hey @ananthakumaran , any chance I can request that you cut a release to include this? I notice it's been a while since a release has been cut anyways. Thanks a bunch!

@ananthakumaran
Copy link
Owner

@cprussin done

@phuhl phuhl deleted the patch-1 branch June 7, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flycheck does not produce errors bcs tsx-tide does not recognize tsx-ts-mode
3 participants