Include data in completionEntryDetails request #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for debugging the issue and the patch. It seems like this info is required to disambiguate the completion with the same name microsoft/TypeScript#42890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At work some changes were made recently to the way module resolution works which broke auto importing in Tide. Other editors such as VSCode were not affected, so we compared the tsserver requests/responses between VSCode and Tide and noticed that
completionEntryDetailswas returning an empty body for Tide but not VSCode. The only difference between the two requests was that VSCode included thedataproperty underentryNames(included in the response from thecompletionsrequest), whereas Tide did not. Patching Tide to includedatafixed the issue.I'm not sure why after these tsconfig changes tsserver no longer can provide completion entry details without the extra data, but the change to support this is minimal so I thought I'd contribute it upstream in case others hit the same issue.