Allow import DB from URL #2532
Merged
Allow import DB from URL #2532
+90
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
import-from-url
branch
from
91efda8 to
46b69e4
Compare
kzantow
approved these changes
Mar 17, 2025
| @@ -443,6 +467,12 @@ func (c curator) Import(path string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| var urlPrefixPattern = regexp.MustCompile("^[a-zA-Z]+://") | |||
There was a problem hiding this comment.
It looks like this will match file://; I think this will end up working fine, since it's supported by go-getter, is that right?
There was a problem hiding this comment.
yup yup -- it supports handling file:// 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables being able to import DBs from a URL (whereas today this must be a local file), so the user does not need to download them first:
This means if you have a previous grype scan with a DB URL in it (added in #2529) you can quickly use that reference to import the DB:
The value in grype JSON documents has the checksum of the argument as a query parameter (
https://grype.anchore.io/databases/v6/vulnerability-db_v6.0.2_2025-03-14T01:31:06Z_1741925227.tar.zst?checksum=sha256%3Ad4654e3b212f1d8a1aaab979599691099af541568d687c4a7c4e7c1da079b9b8), which allows for client side validation:Closes #2134
PR Stack