Yboichuk/app/radio controller #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and3rson
force-pushed
the
main
branch
2 times, most recently
from
e17861d
to
d9904e9
Compare
and3rson
added
enhancement
and3rson
reviewed
Apr 10, 2024
|
|
||
| // TODO: add support for ibus, CRSF and other | ||
|
|
||
| bfs::SbusTx sbus_tx(&Serial2, -1, 12, false); |
There was a problem hiding this comment.
Потрібно десь при запуску програми або в якомусь меню "Інформація" відображати інфо про те, який пін задіяний. Або може навіть варто створити нову сторінку в нашій документації, де описувати мануали всіх програм, які ми пишемо для Кіри
and3rson
reviewed
Apr 10, 2024
| } | ||
|
|
||
| bool RadioControllApp::readSettings() { | ||
| FILE* file = fopen("/sd/RadioContollSetting.csv", "r"); |
There was a problem hiding this comment.
Добре б якусь коротшу назву, щоб вміщалась в браузері файлів і не скролилась, наприклад rc_config.csv
and3rson
reviewed
Apr 10, 2024
|
|
||
| int lineNum = 0; | ||
| char line[100]; | ||
| while (fgets(line, sizeof(line), file)) { |
There was a problem hiding this comment.
Можна використати ArduinoJson, він в нас вже є в залежностях. Приклад:
lilka/firmware/keira/src/apps/weather/weather.cpp
Lines 201 to 203 in b237890
and3rson
force-pushed
the
main
branch
2 times, most recently
from
4563cc8
to
14a952c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App for controll some thing like rc drone, car, plane, ship, etc. via lilka with SBUS. Just need transiver and reciever with SBUS