Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Sabre HTTP 500 error on REPORT requests #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andig
Copy link
Owner

@andig andig commented Dec 5, 2020

Fix #196

@andig andig added the bug label Dec 5, 2020
@blacksenator
Copy link
Collaborator

blacksenator commented Dec 28, 2020

Sorry for delay - took a few days before I found time for testing.
Findings:

  1. PR has no side effects to iCloud requested via REPORT
  2. PR has no side effects to T-Online requested via PROPFIND (see switching the request method #205)
  3. PR throws an error at T-Online requested via REPORT: In Backend.php line 185: String could not be parsed as XML

Case 2:

'server' => [
    [
        'url'      => 'https://spica.t-online.de/spica-contacts/carddav/principals/XXXXXXXX@t-online.de/addressBooks/default/',
        'user'     => 'XXXXXXXX@t-online.de',
        'password' => 'XXXXXXXX',
        'method'   => 'PROPFIND',  // uncomment if 'REPORT' (default) causes an error (e.g. t-online)
        ],
],

@blacksenator
Copy link
Collaborator

According to this feedback I would suggest to close this PR

@andig
Copy link
Owner Author

andig commented Dec 29, 2020

Mit diesem PR sollte es auch mit REPORT laufen- dann aber VIEL schneller als PROPFIND. Ich würde den also nicht schliessen.

@blacksenator
Copy link
Collaborator

blacksenator commented Dec 30, 2020

Ja, bin ja bei Dir: "sollte". Nur hat ja der "implizite" Test von altheeagle mit Baikal* und mein Test mit T-online gezeigt, dass die Änderung nicht den gewünschten Effekt hatte.

  • wobei ich mir nicht sicher bin, ob er tatsächlich den PR als Branch lokal getestet hat...

@andig
Copy link
Owner Author

andig commented Dec 30, 2020

Du könntest bei T-Online mal den nicht parsebaren String ausgeben damit wir sehen was da los ist. Die Zeile steht ja ind er Fehlermeldung.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dav Server reports: The input element to parse is empty.
2 participants