Skip to content

Commit

Permalink
test: unskip tests that now pass on AIX
Browse files Browse the repository at this point in the history
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Backport-PR-URL: nodejs#29599
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
sam-github authored and andrewhughes101 committed Sep 19, 2019
1 parent 3c5a25f commit 9209f48
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 0 additions & 2 deletions test/message/message.status
Expand Up @@ -17,5 +17,3 @@ prefix message
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
vm_dont_display_syntax_error: SKIP
3 changes: 1 addition & 2 deletions test/sequential/sequential.status
Expand Up @@ -25,6 +25,5 @@ test-http2-settings-flood: PASS,FLAKY
[$system==freebsd]

[$system==aix]
# https://github.com/nodejs/node/pull/28469
test-async-wrap-getasyncid: SKIP
# https://github.com/nodejs/node/pull/29054
test-buffer-creation-regression: SKIP

0 comments on commit 9209f48

Please sign in to comment.