Skip to content

Commit

Permalink
Merge pull request #1436 from android/dturner-patch-1
Browse files Browse the repository at this point in the history
Made pull request instructions clearer
  • Loading branch information
dturner committed May 13, 2024
2 parents 3b02f81 + 7c16da9 commit 3cf6f64
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@
_Thanks for submitting a pull request. Please include the following information._
**DO NOT CREATE A PULL REQUEST WITHOUT READING THESE INSTRUCTIONS**

**What I have done and why**
## Instructions
Thanks for submitting a pull request. To accept your pull request we need you do a few things:

**If this is your first pull request**

_Include a summary of what your pull request contains, and why you have made these changes._
- [Sign the contributors license agreement](https://cla.developers.google.com/)

Fixes #<issue_number_goes_here>
**Ensure tests pass and code is formatted correctly**

**How I'm testing it**
- Run local tests on the `DemoDebug` variant by running `./gradlew testDemoDebug`
- Fix code formatting: `./gradlew --init-script gradle/init.gradle.kts spotlessApply`

_Choose at least one:_
- Unit tests
- UI tests
- Screenshot tests
- N/A _(provide justification)_
**Add a description**

**Do tests pass?**
- [ ] Run local tests on `DemoDebug` variant: `./gradlew testDemoDebug`
- [ ] Check formatting: `./gradlew --init-script gradle/init.gradle.kts spotlessApply`
We need to know what you've done and why you've done it. Include a summary of what your pull request contains, and why you have made these changes. Include links to any relevant issues which it fixes.

**Is this your first pull request?**
- [ ] [Sign the CLA](https://cla.developers.google.com/)
- [ ] Run `./tools/setup.sh`
- [ ] Import the code formatting style as explained in [the setup script](/tools/setup.sh#L40).
[Here's an example](https://github.com/android/nowinandroid/pull/1257).

**NOW DELETE THIS LINE AND EVERYTHING ABOVE IT**

**What I have done and why**

\<add your PR description here\>

0 comments on commit 3cf6f64

Please sign in to comment.