Add end of TS input fix to HLS mode

androidx · Jun 14, 2023 · ac4a3fe · ac4a3fe
1 parent 3ed8d64
commit ac4a3fe
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/ts/H263Reader.java b/libraries/extractor/src/main/java/androidx/media3/extractor/ts/H263Reader.java
@@ -220,6 +220,7 @@ public void consume(ParsableByteArray data) {
   public void packetFinished(boolean isEndOfInput) {
     if (isEndOfInput) {
       sampleReader.onDataEnd(totalBytesWritten, 0, hasOutputFormat);
+      sampleReader.reset();
     }
   }
 

diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/ts/H264Reader.java b/libraries/extractor/src/main/java/androidx/media3/extractor/ts/H264Reader.java
@@ -506,6 +506,7 @@ public void end(long position) {
       // Output a final sample with the nal units currently held
       nalUnitStartPosition = position;
       outputSample(0);
+      readingSample = false;
     }
 
     private static final class SliceHeaderData {

diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/ts/H265Reader.java b/libraries/extractor/src/main/java/androidx/media3/extractor/ts/H265Reader.java
@@ -382,6 +382,7 @@ public void end(long position) {
       // Output a final sample with the nal units currently held
       nalUnitPosition = position;
       outputSample(0);
+      readingSample = false;
     }
 
     /** Returns whether a NAL unit type is one that occurs before any VCL NAL units in a sample. */

diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/ts/TsExtractor.java b/libraries/extractor/src/main/java/androidx/media3/extractor/ts/TsExtractor.java
@@ -323,13 +323,11 @@ public void release() {
     }
 
     if (!fillBufferWithAtLeastOnePacket(input)) {
-      if (mode != MODE_HLS) {
-        // Send a dummy pusi to allow for packetFinished to be triggered on the last unit
-        for (int i = 0; i < tsPayloadReaders.size(); i++) {
-          TsPayloadReader payloadReader = tsPayloadReaders.valueAt(i);
-          if (payloadReader instanceof PesReader) {
-            payloadReader.consume(new ParsableByteArray(), FLAG_PAYLOAD_UNIT_START_INDICATOR);
-          }
+      // Send a dummy pusi to allow for packetFinished to be triggered on the last unit
+      for (int i = 0; i < tsPayloadReaders.size(); i++) {
+        TsPayloadReader payloadReader = tsPayloadReaders.valueAt(i);
+        if (payloadReader instanceof PesReader) {
+          payloadReader.consume(new ParsableByteArray(), FLAG_PAYLOAD_UNIT_START_INDICATOR);
         }
       }
       return RESULT_END_OF_INPUT;