Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatroskaExtractor: fixed typo when determining 'rotationDegrees' #461

Merged
merged 2 commits into from
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
* Parse EXIF rotation data for image inputs.
* Track Selection:
* Extractors:
* Fix typo when determining `rotationDegrees`. Changed
`projectionPosePitch` to `projectionPoseRoll`
([#461](https://github.com/androidx/media/pull/461)).
* Audio:
* Audio Offload:
* Add `AudioSink.getFormatOffloadSupport(Format)` that retrieves level of
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2293,12 +2293,12 @@ public void initializeOutput(ExtractorOutput output, int trackId) throws ParserE
// The range of projectionPoseRoll is [-180, 180].
if (Float.compare(projectionPoseRoll, 0f) == 0) {
rotationDegrees = 0;
} else if (Float.compare(projectionPosePitch, 90f) == 0) {
} else if (Float.compare(projectionPoseRoll, 90f) == 0) {
rotationDegrees = 90;
} else if (Float.compare(projectionPosePitch, -180f) == 0
|| Float.compare(projectionPosePitch, 180f) == 0) {
} else if (Float.compare(projectionPoseRoll, -180f) == 0
|| Float.compare(projectionPoseRoll, 180f) == 0) {
rotationDegrees = 180;
} else if (Float.compare(projectionPosePitch, -90f) == 0) {
} else if (Float.compare(projectionPoseRoll, -90f) == 0) {
rotationDegrees = 270;
}
}
Expand Down