Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref #258 - Three Features Sets #259

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

paulvi
Copy link
Contributor

@paulvi paulvi commented Mar 5, 2015

see #258

(for JavaScript committers);
includes Tern Linters as incubating feature
Resources .Features Set
with
tern.eclipse.ide.server.nodejs.embed.source
tern-feature.source
tern-jsdt-feature.source
tern-server-nodejs-feature.source
tern.eclipse.ide.tools.feature.source
tern-linters-feature.source

this commit is not clean: it includes some features.xml from not related
modules. Those files were not modified however EGit marked them modified
and I ocasionally commited with the last commit and don't know how to
remove some files from git commit (git reset --soft HEAD^ dit not help)
@paulvi
Copy link
Contributor Author

paulvi commented Mar 5, 2015

3ef1924 is not clean, but I tried to have every commit having meaning

@paulvi paulvi changed the title ref 258 - Three Features Sets ref #258 - Three Features Sets Mar 5, 2015
@paulvi
Copy link
Contributor Author

paulvi commented Sep 24, 2015

@angelozerr Do you actually need Feature Sets #258 ?

If no, there's no sense of updating PR

@angelozerr
Copy link
Owner

To be honnest with you, none users tell me about "Feature Sets", and I have no time to check your PR (I'm not a big expert with update site), that's why I prefer keeping update site like this. Hope you will understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants