Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Atom type that represents datasinks #4044

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmagin
Copy link
Contributor

@fmagin fmagin commented Jul 27, 2023

Now that FunctionCall atoms don't exist anymore, it got impossible to model questions like whether a certain argument has a dataflow path to a certain function.

As an alternative way to model this, I propose a new kind of Atom that represents the general idea of a sink.

It might also be interesting to have an Atom for datasources, e.g. if a function reads from a file from the filesystem, a FunctionHandler could add this kind of Atom as a dependency. This requires more code changes though, because LiveDefinitions.get_definitions doesn't support this yet.

Overall this is still a Draft PR and a suggestion, I am currently still experimenting with the code built on top of this idea

@fmagin fmagin force-pushed the fmagin/datasink_atoms branch 2 times, most recently from 4b10d97 to fd3f6a9 Compare August 2, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant