Add new Atom type that represents datasinks #4044
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
FunctionCall
atoms don't exist anymore, it got impossible to model questions like whether a certain argument has a dataflow path to a certain function.As an alternative way to model this, I propose a new kind of
Atom
that represents the general idea of a sink.It might also be interesting to have an
Atom
for datasources, e.g. if a function reads from a file from the filesystem, a FunctionHandler could add this kind of Atom as a dependency. This requires more code changes though, becauseLiveDefinitions.get_definitions
doesn't support this yet.Overall this is still a Draft PR and a suggestion, I am currently still experimenting with the code built on top of this idea