Remove SimProcedure for vsnprintf #4424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're not going to emulate it correctly, we shouldn't have it at all.
I'm not sure about this philosophy given the fact that most function summaries are intentionally incorrect. We can definitely add a warning when the vsnprintf SimProcedure is used though. |
|
I can understand that debugging a subtle correctness limitation in a SimProcedure might be more vexing than this but I find it hard to understand why this implementation is useful enough to enable by default… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're not going to emulate it correctly, we shouldn't have it at all.