Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4245 #4473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #4245 #4473

wants to merge 1 commit into from

Conversation

fmagin
Copy link
Contributor

@fmagin fmagin commented Feb 28, 2024 •
edited

This fixes #4245 which is a fairly annoying bug that degrades analysis results a lot.
I don't see any downsides to this fix, any state that tries to access this memory later will still retrieve the static result

@fmagin
Copy link
Contributor Author

fmagin commented Feb 28, 2024

The only test that fails is test_techniques.test_indirectcfi from patchrex, and that's only because of a claripy timeout error, so I'm assuming this is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly added Reverse(Top) Value due to edge case in merge logic
1 participant
@fmagin