fix(eslint-plugin-template): accessibility-elements-content not allowing some attributes/inputs #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
force-pushed
the
fix/accessibility-elements-content
branch
from
5d46820
to
1b34522
Compare
Nx Cloud ReportCI ran the following commands for commit 561336b. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
Nx Cloud ReportCI ran the following commands for commit 1b34522. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
…orting empty `aria-hidden` property
rafaelss95
force-pushed
the
fix/accessibility-elements-content
branch
from
1b34522
to
469d415
Compare
…ing some attributes/inputs
rafaelss95
force-pushed
the
fix/accessibility-elements-content
branch
from
469d415
to
93c823b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st. commit: with this
isHiddenFromScreenReadernow returnstruefor emptyaria-hidden, e.g.:<div aria-hidden></div>;2nd. commit: with this
accessibility-elements-contentnow ignores elements when the attributesaria-hidden,aria-label,outerHTMLandtitleare present.Btw, part of this fix was reported in mgechev/codelyzer#993.
It's also related to jsx-eslint/eslint-plugin-jsx-a11y#423 and its proposed fix jsx-eslint/eslint-plugin-jsx-a11y#727