Skip to content

Commit

Permalink
fix(@schematics/angular): show info message when depending on `rxjs-c…
Browse files Browse the repository at this point in the history
…ompat`

(cherry picked from commit 5a42104)
  • Loading branch information
alan-agius4 committed Jul 27, 2020
1 parent 274673a commit 08bf929
Showing 1 changed file with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,22 @@ export default function (): Rule {

// Check for @angular-devkit/schematics and @angular-devkit/core
for (const name of ['@angular-devkit/schematics', '@angular-devkit/core']) {
const current = getPackageJsonDependency(host, name);
if (current) {
if (getPackageJsonDependency(host, name)) {
context.logger.info(
`Package "${name}" found in the workspace package.json. ` +
'This package typically does not need to be installed manually. ' +
'If it is not being used by project code, it can be removed from the package.json.',
);
}
}

if (getPackageJsonDependency(host, 'rxjs-compat')) {
context.logger.info(
`Package "rxjs-compat" found in the workspace package.json. ` +
'This package typically was used during migration from RxJs version 5 to 6 during the Angular 5 ' +
'timeframe and may no longer be needed.\n' +
'Read more about this: https://rxjs-dev.firebaseapp.com/guide/v6/migration',
);
}
};
}

0 comments on commit 08bf929

Please sign in to comment.