feat(@angular-devkit/build-angular): remove deprecated options

BREAKING CHANGE: With this change we removed several deprecated builder options - `extractCss` has been removed from the browser builder. CSS is now always extracted. - `servePathDefaultWarning` and `hmrWarning` have been removed from the dev-server builder. These options had no effect.
angular · Aug 3, 2021 · 20e48a3 · 20e48a3
1 parent de1d21a
commit 20e48a3
Show file tree

Hide file tree

Showing 29 changed files with 461 additions and 553 deletions.
diff --git a/goldens/public-api/angular_devkit/build_angular/src/index.md b/goldens/public-api/angular_devkit/build_angular/src/index.md
@@ -40,8 +40,6 @@ export interface BrowserBuilderOptions {
     crossOrigin?: CrossOrigin;
     deleteOutputPath?: boolean;
     deployUrl?: string;
-    // @deprecated
-    extractCss?: boolean;
     extractLicenses?: boolean;
     fileReplacements?: FileReplacement[];
     i18nMissingTranslation?: I18NMissingTranslation;

diff --git a/package.json b/package.json
@@ -211,7 +211,6 @@
     "source-map-loader": "3.0.0",
     "source-map-support": "0.5.19",
     "spdx-satisfies": "^5.0.0",
-    "style-loader": "3.2.1",
     "stylus": "0.54.8",
     "stylus-loader": "6.1.0",
     "symbol-observable": "4.0.0",

diff --git a/packages/angular_devkit/build_angular/BUILD.bazel b/packages/angular_devkit/build_angular/BUILD.bazel
@@ -173,7 +173,6 @@ ts_library(
         "@npm//semver",
         "@npm//source-map-loader",
         "@npm//source-map-support",
-        "@npm//style-loader",
         "@npm//stylus",
         "@npm//stylus-loader",
         "@npm//terser",

diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json
@@ -62,7 +62,6 @@
     "semver": "7.3.5",
     "source-map-loader": "3.0.0",
     "source-map-support": "0.5.19",
-    "style-loader": "3.2.1",
     "stylus": "0.54.8",
     "stylus-loader": "6.1.0",
     "terser": "5.7.1",

diff --git a/packages/angular_devkit/build_angular/src/browser/schema.json b/packages/angular_devkit/build_angular/src/browser/schema.json
@@ -237,12 +237,6 @@
         }
       ]
     },
-    "extractCss": {
-      "type": "boolean",
-      "description": "Extract CSS from global styles into '.css' files instead of '.js'.",
-      "default": true,
-      "x-deprecated": "Deprecated since version 11.0. No longer required to disable CSS extraction for HMR."
-    },
     "watch": {
       "type": "boolean",
       "description": "Run build when files change.",

diff --git a/packages/angular_devkit/build_angular/src/browser/specs/optimization-level_spec.ts b/packages/angular_devkit/build_angular/src/browser/specs/optimization-level_spec.ts
@@ -41,7 +41,6 @@ describe('Browser Builder optimization level', () => {
         scripts: false,
       },
       aot: true,
-      extractCss: true,
       styles: ['src/styles.css'],
     };
 
@@ -64,7 +63,6 @@ describe('Browser Builder optimization level', () => {
         scripts: true,
       },
       aot: true,
-      extractCss: true,
       styles: ['src/styles.css'],
     };
 

diff --git a/packages/angular_devkit/build_angular/src/browser/specs/resources-output-path_spec.ts b/packages/angular_devkit/build_angular/src/browser/specs/resources-output-path_spec.ts
@@ -49,7 +49,6 @@ describe('Browser Builder styles resources output path', () => {
     // Check base paths are correctly generated.
     const overrides = {
       aot: true,
-      extractCss: true,
       resourcesOutputPath: 'out-assets',
     };
 
@@ -78,7 +77,7 @@ describe('Browser Builder styles resources output path', () => {
     writeFiles();
 
     // Check base paths are correctly generated.
-    const overrides = { aot: true, extractCss: true };
+    const overrides = { aot: true };
     const { files } = await browserBuild(architect, host, target, overrides);
     const styles = await files['styles.css'];
     const main = await files['main.js'];

diff --git a/packages/angular_devkit/build_angular/src/browser/specs/source-map_spec.ts b/packages/angular_devkit/build_angular/src/browser/specs/source-map_spec.ts
@@ -23,7 +23,6 @@ describe('Browser Builder source map', () => {
   it('works', async () => {
     const overrides = {
       sourceMap: true,
-      extractCss: true,
       styles: ['src/styles.css'],
     };
 
@@ -77,7 +76,6 @@ describe('Browser Builder source map', () => {
         styles: true,
         scripts: true,
       },
-      extractCss: true,
       styles: ['src/styles.scss'],
     };
 
@@ -98,7 +96,6 @@ describe('Browser Builder source map', () => {
         styles: true,
         scripts: false,
       },
-      extractCss: true,
       styles: ['src/styles.scss'],
     };
 
@@ -119,7 +116,6 @@ describe('Browser Builder source map', () => {
         styles: false,
         scripts: true,
       },
-      extractCss: true,
       styles: ['src/styles.scss'],
     };
 
@@ -141,7 +137,6 @@ describe('Browser Builder source map', () => {
         styles: true,
         scripts: true,
       },
-      extractCss: true,
       styles: ['src/styles.scss'],
     };
 
@@ -162,7 +157,6 @@ describe('Browser Builder source map', () => {
   it('should resolve sources to partial SCSS files', async () => {
     const overrides = {
       sourceMap: true,
-      extractCss: true,
       styles: ['src/styles.scss'],
     };