fix(@angular-devkit/build-angular): sourceMap option not working in t…

…ests Fixes #13766
angular · Feb 26, 2019 · 324b256 · 324b256
1 parent 3420f66
commit 324b256
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/test.ts b/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/test.ts
@@ -60,8 +60,8 @@ export function getTestConfig(
     const { styles, scripts } = wco.buildOptions.sourceMap;
 
     extraPlugins.push(getSourceMapDevTool(
-      styles,
-      scripts,
+      scripts || false,
+      styles || false,
       false,
       true,
     ));

diff --git a/tests/legacy-cli/e2e/tests/test/test-sourcemap.ts b/tests/legacy-cli/e2e/tests/test/test-sourcemap.ts
@@ -0,0 +1,29 @@
+import { writeFile } from '../../utils/fs';
+import { execAndWaitForOutputToMatch, killAllProcesses } from '../../utils/process';
+import { updateJsonFile } from '../../utils/project';
+
+export default async function () {
+  await updateJsonFile('angular.json', configJson => {
+    const appArchitect = configJson.projects['test-project'].architect;
+    appArchitect.test.options.sourceMap = {
+      scripts: true,
+    };
+  });
+
+  await writeFile('src/app/app.component.spec.ts', `
+      it('show fail', () => {
+        expect(undefined).toBeTruthy();
+      });
+    `);
+
+  // when sourcemaps are not working the stacktrace won't point to the spec.ts file.
+  try {
+    await execAndWaitForOutputToMatch(
+      'ng',
+      ['test', '--watch', 'false'],
+      /app\.component\.spec\.ts/,
+    );
+  } finally {
+    killAllProcesses();
+  }
+}