fix(@schematics/angular): remove reference to tsconfig.spec.json in t…

…sconfig.json when minimal=true
angular · Jul 20, 2020 · a14c80a · a14c80a
1 parent 6c09023
commit a14c80a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/schematics/angular/application/index.ts b/packages/schematics/angular/application/index.ts
@@ -418,7 +418,7 @@ export default function (options: ApplicationOptions): Rule {
         ]), MergeStrategy.Overwrite),
       addTsConfigProjectReferences([
         join(appDir, 'tsconfig.app.json'),
-        join(appDir, 'tsconfig.spec.json'),
+        ... options.minimal ? [] : [join(appDir, 'tsconfig.spec.json')],
       ]),
       options.minimal ? noop() : schematic('e2e', e2eOptions),
       options.skipPackageJson ? noop() : addDependenciesToPackageJson(options),

diff --git a/packages/schematics/angular/application/index_spec.ts b/packages/schematics/angular/application/index_spec.ts
@@ -91,6 +91,17 @@ describe('Application Schematic', () => {
     ]);
   });
 
+  it('minimal=true should add correct reference in tsconfig', async () => {
+    const options = { ...defaultOptions, minimal: true };
+    const tree = await schematicRunner.runSchematicAsync('application', options, workspaceTree)
+      .toPromise();
+
+    const { references } = readJsonFile(tree, '/tsconfig.json');
+    expect(references).toEqual([
+      { path: './projects/foo/tsconfig.app.json' },
+    ]);
+  });
+
   it('should set the prefix to app if none is set', async () => {
     const options = { ...defaultOptions };