Skip to content

Commit

Permalink
fix(@angular-devkit/core): update logger forEach promiseCtor type
Browse files Browse the repository at this point in the history
`typeof Promise` and `PromiseConstructorLike` are not the same thing. This causes issues in G3 when `strictNullChecks` are being enabled using RXJS 7.

(cherry picked from commit cf1b778)
  • Loading branch information
alan-agius4 committed Oct 14, 2022
1 parent 7cbc445 commit de467f4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion goldens/public-api/angular_devkit/core/index.md
Expand Up @@ -459,7 +459,7 @@ class Logger extends Observable<LogEntry> implements LoggerApi {
// (undocumented)
fatal(message: string, metadata?: JsonObject): void;
// (undocumented)
forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void>;
forEach(next: (value: LogEntry) => void, promiseCtor?: PromiseConstructorLike): Promise<void>;
// (undocumented)
info(message: string, metadata?: JsonObject): void;
// (undocumented)
Expand Down
5 changes: 4 additions & 1 deletion packages/angular_devkit/core/src/logger/logger.ts
Expand Up @@ -162,7 +162,10 @@ export class Logger extends Observable<LogEntry> implements LoggerApi {
);
}

override forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void> {
override forEach(
next: (value: LogEntry) => void,
promiseCtor?: PromiseConstructorLike,
): Promise<void> {
return this._observable.forEach(next, promiseCtor);
}
}

0 comments on commit de467f4

Please sign in to comment.