Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lintFix to all generate commands #12894

Closed
Kunepro opened this issue Nov 8, 2018 · 1 comment · Fixed by #12938
Closed

Add lintFix to all generate commands #12894

Kunepro opened this issue Nov 8, 2018 · 1 comment · Fixed by #12938

Comments

@Kunepro
Copy link

Kunepro commented Nov 8, 2018

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ X ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ X ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

NPM: 6.4.1
Angular CLI: 7.0.3
Node: 10.12.0
OS: darwin x64
Angular: 7.0.1
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

Package Version

@angular-devkit/architect 0.8.3
@angular-devkit/build-angular 0.8.3
@angular-devkit/build-optimizer 0.8.3
@angular-devkit/build-webpack 0.8.3
@angular-devkit/core 0.8.3
@angular-devkit/schematics 7.0.3
@angular/cdk 7.0.2
@angular/cli 7.0.3
@angular/material 7.0.2
@ngtools/webpack 6.2.3
@schematics/angular 7.0.3
@schematics/update 0.10.3
rxjs 6.3.3
typescript 3.1.3
webpack 4.20.2

Repro steps

ng generate module some-module --lintFix=true

Expected generated module to be tslint fixed like happens with components, however no changes.

The log given by the failure

No changes in the module, components are fixed and spaces replaced by tabs, modules are not.
I only tested with modules, but I expect that all the other ng generate commands have the same issue.

Desired functionality

ng generate to support lintFix

Mention any other details that might be useful

@ngbot ngbot bot added this to the Backlog milestone Nov 8, 2018
@alan-agius4 alan-agius4 added severity1: confusing needs: discussion On the agenda for team meeting to determine next steps and removed needs: discussion On the agenda for team meeting to determine next steps labels Nov 12, 2018
mgechev pushed a commit that referenced this issue Dec 13, 2018
At the moment some schematics contain this options for instance the `guard`, `component` etc.. But some others don't such as `module`

Fixes #12894 and Fixes #6272
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants